Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats: Track stream reassembly drops #9405

Closed
wants to merge 1 commit into from
Closed

stats: Track stream reassembly drops #9405

wants to merge 1 commit into from

Conversation

jlucovsky
Copy link
Contributor

@jlucovsky jlucovsky commented Aug 22, 2023 •
edited

Issue: 6235

Track drops due to reassembly memcap limits under a different enum for discrete reporting.

Link to redmine ticket: 6235

Describe changes:

  • Track reassembly drops under a different enum for discrete stat/reporting.

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=pr/1357
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

@jlucovsky jlucovsky requested review from victorjulien and a team as code owners August 22, 2023 14:26
@jlucovsky
Copy link
Contributor Author

@jufajardini Please review.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 15683

jufajardini
jufajardini approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me :)

Only thing I'm not sure about is the unrelated json schema change in the same commit.

@jufajardini
Copy link
Contributor

CI checks failing because CI didn't the SV PR.

jasonish
jasonish reviewed Aug 22, 2023
View reviewed changes
etc/schema.json
Comment on lines -43 to +44
"$comment": "May change to sensor_name in the future, or become user configurable: https://redmine.openinfosecfoundation.org/issues/4919",
"$comment":
"May change to sensor_name in the future, or become user configurable: https://redmine.openinfosecfoundation.org/issues/4919",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing your editor didn't like this long line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-format made that change.

@jlucovsky jlucovsky mentioned this pull request Aug 23, 2023
Closed
@jlucovsky
Copy link
Contributor Author

Continued in #9408

@jlucovsky jlucovsky closed this Aug 23, 2023
@jlucovsky jlucovsky deleted the 6235/1 branch October 21, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish jasonish left review comments

@jufajardini jufajardini jufajardini approved these changes

@victorjulien victorjulien Awaiting requested review from victorjulien victorjulien is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@jlucovsky @suricata-qa @jufajardini @jasonish