detect/rule: Use correct buffer index for sizing mpm_stats array #9489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes a second, unnecessary increment of the de_ctx buffer id. Issue: 5211
This commit uses the detect engine buffer id instead of the global value. Issue: 5211
Issue: 5211
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9489 +/- ##
==========================================
- Coverage 82.17% 82.17% -0.01%
==========================================
Files 968 968
Lines 274202 274200 -2
==========================================
- Hits 225328 225320 -8
- Misses 48874 48880 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Sep 15, 2023
|
Information: QA ran without warnings. Pipeline 15959 |
Merged
|
Merged in #9492, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket: 5211
Describe changes:
Provide values to any of the below to override the defaults.
To use a pull request use a branch name like
pr/NwhereNis thepull request number.
Alternatively,
SV_BRANCHmay also be a link to anOISF/suricata-verify pull-request.