Collect device stats close to the packet receive loop function v1 #9490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 15, 2023 06:21
To better represent port stats of Suricata stop the device right after Suricata is deemed to shut down. While Suricata deinitialization happened, the device kept receiving packets. But because Suricata was no longer interested in the packets, the device accounted these packets as missed and it could have alter true stats of Suricata.
While Suricata initializes, the device must be started to e.g. apply rte_flow rules on some devices. But in the meantime, the NIC started receiving packets but accounted those as missed. Stats reset was added to better represent true packet drop.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9490 +/- ##
=======================================
Coverage 82.17% 82.17%
=======================================
Files 968 968
Lines 274202 274202
=======================================
+ Hits 225328 225331 +3
+ Misses 48874 48871 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Sep 15, 2023
Merged
|
Information: QA ran without warnings. Pipeline 15961 |
|
Merged in #9492, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes DPDK stats more accurate.
Link to redmine ticket:
Describe changes: