Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnint 64to32 6186 v11 #9530

Closed
wants to merge 16 commits into from

Conversation

catenacyber
Copy link
Contributor

[Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186

Describe changes:

  • fix -Wshorten-64-to-32 warnings for some files
  • Add CI build with this warning
LIBHTP_BRANCH=pr/399

OISF/libhtp#399

#9514 with all fixes for CI

There must be some stuff to review more carefully

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #9530 (571f675) into master (af4bb91) will decrease coverage by 0.04%.
The diff coverage is 70.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9530      +/-   ##
==========================================
- Coverage   82.19%   82.15%   -0.04%     
==========================================
  Files         968      968              
  Lines      274203   274276      +73     
==========================================
- Hits       225373   225340      -33     
- Misses      48830    48936     +106     
Flag Coverage Δ
fuzzcorpus 64.01% <59.06%> (-0.08%) ⬇️
suricata-verify 60.89% <64.32%> (-0.06%) ⬇️
unittests 62.86% <36.89%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@catenacyber
Copy link
Contributor Author

Replaced by #9542

@catenacyber catenacyber closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant