-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: JA4 for TLS and QUIC -- v2 #9545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work Sascha :-)
- CI : pending
- Code : doing right now
- Commits segmentation : one commit will be enough in the end
- Commit messages : Could you please put a reference to the ticket number in the commit message ?
- Git ID set : looks fine for me
- CLA : you already contributed
- Doc update : should there be rules keywords for these ?
- Redmine ticket : ok
- Rustfmt : Could you please run it ? quic is supposed to be all rustfmted...
- Tests : Suricata-verify tests look fine, some comments there
- Dependencies added: none
No problem, it's been a long weekend here and I appreciated the opportunity to dive into Rust again :)
Totally.
Ah, the usual :P Sure.
Definitely, that's kind of the point. Will add these in the next iteration.
Sure. |
Next PR: #9553 |
Previous PR: #9536
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6379
Changes to previous PR: