New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install: Be consistent with use of the "sudo" - v1 #9552
Conversation
Included the "sudo" command to commands that need to be executed with the super-user privilege.
Thanks for your contribution. With respect to the details of the commit itself, could you make the following changes:
|
sudo echo "deb http://http.debian.net/debian buster-backports main" > \ | ||
/etc/apt/sources.list.d/backports.list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular command will actually fail when sudo is added, instead it should probably be:
echo "deb http://http.debian.net/debian buster-backports main" | sudo tee -a /etc/apt/sources.list.d/backports.list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right! Thank you for the feedback.
We probably also need a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some updates required. Thanks!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9552 +/- ##
==========================================
- Coverage 82.20% 82.19% -0.01%
==========================================
Files 968 968
Lines 274275 274275
==========================================
- Hits 225461 225435 -26
- Misses 48814 48840 +26
Flags with carried forward coverage won't be shown. Click here to find out more. |
Installing |
Where I often get stuck is... I install minimal system, usually in a container. Then cut and paste a page of instructions that use sudo, but sudo isn't there. Usually a quick |
re: a quick You know majority of these packages cannot be used without sudo or root privileges. |
Yes, but you can build, install, run Suricata-Verify, and do a lot of development before ever needing sudo. But its kind of beside the point, its about providing instructions that just work, with a note about where they might not work for you, like on a minimal install, or someone setting up their environment in docker. |
Yes I understand. What I'm saying is, in the case a user wants to take the So I'll have to put these details into the doc then, right? |
No, I've never had to do that. Usually when you don't have sudo already installed, you're dropped in as root. A container is a great example of this, or even many GitHub/Copilot dev containers. Our instructions here will fail if I just go cut and paste them. So just simply a note that the following instructions require sudo. Sphinx provides a markup for these types of note with something like |
OK! I understand you now. So I should just specify at the beginning of each distro sub-heading a note that OK! On it. |
|
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/5720
Describe changes: