New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust doc: add docstring to rust module files - v1 #9579
Conversation
Documentation: OISF#4584
NOTE: This PR may contain new authors:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: our commit messages aren't usually started with capital letter, can you please use something like rust/doc
?
For the mod
file, could you please add something that indicates that? Eg. Template Application layer module
, with the necessary rewordings, of course :P
There are lots of CI failures, but the ones I checked seemed connected to an inline comment I've left, so I'd suggest addressing that and seeing if things improve. :)
//! Gap handling and Chunk-based file transfer tracker. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo clippy
isn't happy with this doc comment (cf error[E0753]: expected outer doc comment). I'm not sure why, but I'm wondering if that's because we have a previous comment before.
I would suggest either removing this, as this module has a description, already, or moving this doc comment to before the file and author comment...
OK, you mean for each mod file, to indicate that it is a mod file, yeah? |
You mean something like; Like this? |
Yes, basically :) |
Yup, looks better to me :) |
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/4584
Describe changes: