Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect: SigMatchAppendSMToList can fail #9588

Closed
wants to merge 1 commit into from
Closed

detect: SigMatchAppendSMToList can fail #9588

wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6104

Describe changes:

  • fixes buffer overflow in rules parsing
  • fixes memory leak in parsing dcerpc.iface on OOM condition (if SigMatchAlloc returns NULL)

Replaces #9485 with needed rebase and commit reworded to explain the revert of 299ee6e

@catenacyber
detect: SigMatchAppendSMToList can fail
f93276d 
Ticket: OISF#6104

And failures should be handled to say that the rule failed to load

Reverts the fix by 299ee6e
that was simple, but not complete (memory leak),
to have this bigger API change which simplifies code.
@catenacyber catenacyber mentioned this pull request Oct 10, 2023
Closed
@victorjulien victorjulien added this to the 8.0 milestone Oct 11, 2023
@suricata-qa
Copy link

ERROR:

ERROR: QA failed on build_asan.

Pipeline 16250

@catenacyber catenacyber mentioned this pull request Oct 19, 2023
Closed
@catenacyber
Copy link
Contributor Author

Replaced by #9662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien victorjulien approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
8.0
3 participants
@catenacyber @suricata-qa @victorjulien