Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpdk: add interrupt (power-saving) mode v2 #9595

Closed
wants to merge 1 commit into from

Conversation

lukashino
Copy link
Contributor

Follow-up of #9583

When packet load is low, Suricata can run in interrupt mode. This more resembles the classic approach of processing packets - CPU cores run low and only fetch packets on interrupt.

Link to redmine ticket:

Describe changes:

  • PR comments
  • added docs

When packet load is low, Suricata can run in interrupt
mode. This more resembles the classic approach of processing
packets - CPU cores run low and only fetch packets
on interrupt.

Ticket: OISF#5839
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #9595 (8000ce2) into master (1a132f4) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9595      +/-   ##
==========================================
+ Coverage   82.28%   82.33%   +0.04%     
==========================================
  Files         968      968              
  Lines      274275   274275              
==========================================
+ Hits       225700   225824     +124     
+ Misses      48575    48451     -124     
Flag Coverage Δ
fuzzcorpus 64.49% <ø> (+0.16%) ⬆️
suricata-verify 60.92% <ø> (-0.01%) ⬇️
unittests 62.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jasonish
Copy link
Member

Interrupt mode sounds OK. Seems the 100% CPU usage mode is the polling mode, even tho in interrupt mode we use poll style calls ;)

Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes requested, but haven't looked at the actual code yet.

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left inline comments from doc-related review :)

doc/userguide/capture-hardware/dpdk.rst Show resolved Hide resolved
doc/userguide/capture-hardware/dpdk.rst Show resolved Hide resolved
doc/userguide/capture-hardware/dpdk.rst Show resolved Hide resolved
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 16244

@lukashino
Copy link
Contributor Author

Continues in #9689

@lukashino lukashino closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants