runmodes: clear hint when runmode is not indicated v4 #9743
Conversation
| default: | ||
| break; | ||
| if (suri->run_mode == RUNMODE_UNKNOWN) { | ||
| SCLogError("No capture mode specified as a command-line argument, specify one from the " |
There was a problem hiding this comment.
I find the output of --list-runmodes to be pretty much useless right now, so I think that needs to be fixed first.
There was a problem hiding this comment.
To add more context to this comment: the contributions in this PR are important, but before we can move on with them, we'll have to rethink what we want the --list-runmodes output to look like. We'll try to tackle that in the next couple days, then we'll get back to this task. :)
There was a problem hiding this comment.
To add more context to this comment: the contributions in this PR are important, but before we can move on with them, we'll have to rethink what we want the
--list-runmodesoutput to look like. We'll try to tackle that in the next couple days, then we'll get back to this task. :)
Okay
There was a problem hiding this comment.
@jufajardini is there another redmine ticket to link to https://redmine.openinfosecfoundation.org/issues/5711 (as it is blocking 5711) ?
There was a problem hiding this comment.
@catenacyber Do you mean a ticket to refactor --list-runmodes? There is, now: https://redmine.openinfosecfoundation.org/issues/6572
There was a problem hiding this comment.
I've updated the ticket to add a suggestion.
|
Hi there, according to our guidelines for stale PRs, I'm closing this. Thanks for your interest in contributing to our project, and feel free to reach out in case you have time and want to contribute to Suricata again, or if you're still working on this task! :) :) https://docs.suricata.io/en/latest/devguide/contributing/github-pr-workflow.html#mergeable-pull-requests |
Ticket: 5711
Link to redmine ticket:
Describe changes:
Previous PR: #9740