Dev log rollover v4 - Signal Based Logfile Rotation #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 23, 2014 10:09
in file rotation on SIGHUP.
for log rotation. Have the LogFileCtx handle the log rotation.
Useful for using passing the buffer through to another writer such as LogFileCtx.
- alert debug log - fast log - stats log - dns log - drop log - file log - http log - tls log - eve/json log
|
I'm wondering how this will work with the unix-socket runmode. There the logger threads are created and destroyed per pcap. How will this affect the 'reload' flag? As I'm not seeing a unregister call, I fear we may end up with dangling pointers there. |
|
Good point. I wonder if this type of rotation should be disabled in this mode? |
|
I would prefer to just handle it, so that we don't have too many exceptions. If we can 'un-register' at thread shutdown, it should automatically handle this case. |
Closed
inliniac
pushed a commit
that referenced
this pull request
Nov 21, 2014
Have -T / --init-errors-fatal process all rules so that it's easier to debug problems in ruleset. Otherwise it can be a lengthy fix, test error cycle if multiple rules have issues. Convert empty rulefile error into a warning. Bug #977
inliniac
pushed a commit
that referenced
this pull request
Nov 23, 2014
Have -T / --init-errors-fatal process all rules so that it's easier to debug problems in ruleset. Otherwise it can be a lengthy fix, test error cycle if multiple rules have issues. Convert empty rulefile error into a warning. Bug #977
inliniac
pushed a commit
that referenced
this pull request
Nov 27, 2014
Have -T / --init-errors-fatal process all rules so that it's easier to debug problems in ruleset. Otherwise it can be a lengthy fix, test error cycle if multiple rules have issues. Convert empty rulefile error into a warning. Bug #977
inliniac
pushed a commit
that referenced
this pull request
Dec 4, 2014
Have -T / --init-errors-fatal process all rules so that it's easier to debug problems in ruleset. Otherwise it can be a lengthy fix, test error cycle if multiple rules have issues. Convert empty rulefile error into a warning. Bug #977
inliniac
pushed a commit
that referenced
this pull request
Dec 5, 2014
Have -T / --init-errors-fatal process all rules so that it's easier to debug problems in ruleset. Otherwise it can be a lengthy fix, test error cycle if multiple rules have issues. Convert empty rulefile error into a warning. Bug #977
ndenev
pushed a commit
to ndenev/suricata
that referenced
this pull request
Feb 5, 2015
Have -T / --init-errors-fatal process all rules so that it's easier to debug problems in ruleset. Otherwise it can be a lengthy fix, test error cycle if multiple rules have issues. Convert empty rulefile error into a warning. Bug OISF#977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates PR #871.
This PR is just a rebase.
Buildbot: