Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment ac rust/v2 #9896

Closed
wants to merge 8 commits into from

Conversation

victorjulien
Copy link
Member

Experiment to see if we can use aho-corasick Rust crate for our MPM.

https://redmine.openinfosecfoundation.org/issues/3847

TODOs

  • test
  • move AC code into their own rust files
  • optimize match loop (+tests)
  • probably more

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #9896 (257a909) into master (d005fff) will decrease coverage by 0.16%.
The diff coverage is 90.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9896      +/-   ##
==========================================
- Coverage   82.45%   82.29%   -0.16%     
==========================================
  Files         972      973       +1     
  Lines      273057   273887     +830     
==========================================
+ Hits       225156   225403     +247     
- Misses      47901    48484     +583     
Flag Coverage Δ
fuzzcorpus 63.78% <85.97%> (-0.59%) ⬇️
suricata-verify 61.05% <85.97%> (-0.05%) ⬇️
unittests 62.98% <90.35%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

ERROR:

ERROR: QA failed on TREX_GENERIC_collect.

Pipeline 16734

@victorjulien
Copy link
Member Author

replaced by #9902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants