6.0.x backport: multi-tenancy: ASAN error on engine analysis #9910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds validation of the bsize value(s) with the available buffer size. Signatures are flagged if the bsize and buffer size are incompatible. Issue: 3682 (cherry picked from commit ecfdc24)
Ticket: 2982 This commit validates that the content usage in a rule will not exceed the dsize value. Values of distance that cause the right edge to be exceeded are considered an error and the signature will be rejected. (cherry picked from commit 7eb5fb1)
Issue: 6239 This commit moves the global variables associated with engine analysis into the detect engine context. Doing so provides encapsulation of the analysis components as well as thread-safe operation in a multi-tenant (context) deployment. (cherry picked from commit c8615bc)
|
Why are the bsize/dsize commits part of this? |
|
Information: QA ran without warnings. Pipeline 16775 |
|
Continued in #9927 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport the multi-tenancy changes needed to avoid ASAN issues when running
--engine-analysisAdditionally, update the
suricata-verifytests to work in 6.0.x; there were 4 tests requiring message updates for successful test outcomesLink to redmine ticket: 6549
Describe changes:
Provide values to any of the below to override the defaults.
To use a pull request use a branch name like
pr/NwhereNis thepull request number.
Alternatively,
SV_BRANCHmay also be a link to anOISF/suricata-verify pull-request.