Experiment ac rust/v11 #9911
Closed
Experiment ac rust/v11 #9911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPM_HS does not need a guard.
Bring implementation in line with Hyperscan, which only counts unique matches. Update test to reflect the new behavior.
Bring implementation in line with Hyperscan, which only counts unique matches. Update test to reflect the new behavior.
Fall back to default matcher. Ticket OISF#6586.
Avoid redundant pointer checks; instead check once.
Count uniq matches only, like the Hyperscan implementation. Default to single context, similar to other algos. Ticket: OISF#3847.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #9911 +/- ##
==========================================
- Coverage 82.45% 82.39% -0.07%
==========================================
Files 972 972
Lines 273057 272519 -538
==========================================
- Hits 225156 224538 -618
- Misses 47901 47981 +80
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
force-pushed
the
experiment-ac-rust/v11
branch
from
3221bd7
to
4e25f54
Compare
Closed
victorjulien
commented
Nov 28, 2023
rust/src/mpm_ac_rs.rs
Outdated
| { | ||
| let haystack = build_slice!(data, data_len as usize); | ||
| let mut match_cnt : u32 = 0; | ||
| // array of bools for patterns we found |
There was a problem hiding this comment.
comment is wrong, it's used as a bitarray now
|
Updated numbers after setting "kind" to DFA based on BurntSushi/aho-corasick#136 (comment) Intel Xeon W-2245So in open, this improves things from 28.2b to 16b ticks. AMD Threadripper 2990wxOpen: 22.7b -> 14.2b |
|
WARNING:
Pipeline 16764 |
|
Information: QA ran without warnings. Pipeline 16765 |
|
Direct DFA calls attempt has the following results Intel Xeon W-2245So a small improvement over the last attempt. AMD Threadripper 2990wxAlso a small improvement, but still not where we'd hope things to land. |
|
Explicitly disabling the prefilter feature seems to have a minimal effect. |
|
WARNING:
Pipeline 16777 |
|
Information: QA ran without warnings. Pipeline 16779 |
|
Performance wasn't there to justify doing more work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace #9904, includes #9908
Implement "ac-rs" using the aho-corasick Rust crate. Sadly, it doesn't give the performance I hoped for. Don't see more ways to optimize it.
Results
Intel Xeon E5-2680v4
HS almost 3x AC-RS, AC almost 2x AC-RS.
AMD Threadripper 2990wx
AC almost 2x
Intel Xeon W-2245
HS is 3x the perf, AC 2x.