Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustfmt 3836 v1 #9924

Closed
wants to merge 3 commits into from
Closed

Rustfmt 3836 v1 #9924

wants to merge 3 commits into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3836

Describe changes:

  • format rust code

@victorjulien
Copy link
Member

Very torn on this. On the one hand it would be nice to do and have the CI. On the other hand will it complicate all backports, and probably make any type of backport automation impossible.

@catenacyber
Copy link
Contributor Author

Very torn on this. On the one hand it would be nice to do and have the CI. On the other hand will it complicate all backports, and probably make any type of backport automation impossible.

See #9072 (comment)

This old PR is an alternative making incremental changes to get rust formatted.
And the conclusion was that we would format it all for 8...

I wonder why formatting broke the build though...

@catenacyber
Copy link
Contributor Author

Replaced by #9928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

@victorjulien victorjulien Awaiting requested review from victorjulien victorjulien is a code owner

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@catenacyber @victorjulien @jasonish