more linting

OJ · Jan 4, 2021 · 8a31cc4 · 8a31cc4
1 parent 02fc16d
commit 8a31cc4
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -14,6 +14,9 @@ linters:
     - goerr113
     - gofumpt
     - exhaustivestruct
+    - forbidigo
+    - nlreturn
+    - wrapcheck
 
 issues:
   exclude-rules:
@@ -25,6 +28,10 @@ issues:
       linters:
         - gocritic
 
+    - text: exitAfterDefer
+      linters:
+        - gocritic
+
     - path: cli\\cmd\\.+\.go
       linters:
         - gochecknoinits

diff --git a/cli/cmd/root.go b/cli/cmd/root.go
@@ -9,7 +9,6 @@ import (
 	"os/signal"
 
 	"github.com/OJ/gobuster/v3/libgobuster"
-
 	"github.com/spf13/cobra"
 )
 

diff --git a/helper/helper_test.go b/helper/helper_test.go
@@ -9,7 +9,6 @@ import (
 
 func TestParseExtensions(t *testing.T) {
 	t.Parallel()
-
 	var tt = []struct {
 		testName           string
 		extensions         string
@@ -41,7 +40,6 @@ func TestParseExtensions(t *testing.T) {
 
 func TestParseCommaSeparatedInt(t *testing.T) {
 	t.Parallel()
-
 	var tt = []struct {
 		testName      string
 		stringCodes   string

diff --git a/libgobuster/helpers_test.go b/libgobuster/helpers_test.go
@@ -161,7 +161,9 @@ func TestLineCounter(t *testing.T) {
 		{"Empty", "", 1},
 	}
 	for _, x := range tt {
+		x := x // NOTE: https://github.com/golang/go/wiki/CommonMistakes#using-goroutines-on-loop-iterator-variables
 		t.Run(x.testName, func(t *testing.T) {
+			t.Parallel()
 			r := strings.NewReader(x.s)
 			l, err := lineCounter(r)
 			if err != nil {