Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipe #376

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft

Pipe #376

wants to merge 23 commits into from

Conversation

james58899
Copy link
Member

@james58899 james58899 commented Apr 15, 2021 •
edited

外觀

  • 本體
  • 連接
  • IO
  • 傳輸中物品

功能

  • 抽取
  • 輸出
  • 儲存
  • 傳輸

@james58899 james58899 added status: wip This pr is working in progess system: block type: feature New feature labels Apr 15, 2021
@james58899 james58899 self-assigned this Apr 15, 2021
@james58899
Merge branch 'master' into pipe
3b39805 
# Conflicts:
#	src/main/java/one/oktw/galaxy/mixin/tweak/MixinCustomBlockEntity_BarrierBlock.java
#	src/main/kotlin/one/oktw/galaxy/block/entity/ModelCustomBlockEntity.kt
@james58899
Impl pipe side mode
a835589
@james58899 james58899 marked this pull request as ready for review July 8, 2021 14:08
@james58899 james58899 added status: needs review This pr needs review status: needs testing This pr needs testing and removed status: wip This pr is working in progess labels Jul 8, 2021
jimchen5209
jimchen5209 requested changes Jul 8, 2021
View reviewed changes
Copy link
Member

@jimchen5209 jimchen5209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

將是 nbt 但變數名稱是 tag 的變數統一成 nbt

src/main/kotlin/one/oktw/galaxy/block/entity/ModelCustomBlockEntity.kt Outdated Show resolved Hide resolved
src/main/kotlin/one/oktw/galaxy/block/entity/PipeBlockEntity.kt Outdated Show resolved Hide resolved
src/main/kotlin/one/oktw/galaxy/block/pipe/ItemTransferPacket.kt Outdated Show resolved Hide resolved
src/main/kotlin/one/oktw/galaxy/util/CompoundTagExt.kt Outdated Show resolved Hide resolved
src/main/kotlin/one/oktw/galaxy/block/pipe/ItemTransferPacket.kt Outdated Show resolved Hide resolved
jimchen5209
jimchen5209 approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@jimchen5209 jimchen5209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Passed

Looks good

@jimchen5209 jimchen5209 removed the status: needs review This pr needs review label Jul 8, 2021
@james58899 james58899 marked this pull request as draft July 18, 2021 06:03
@jimchen5209 jimchen5209 added status: wip This pr is working in progess and removed status: needs testing This pr needs testing labels Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimchen5209 jimchen5209 jimchen5209 approved these changes

Assignees

@james58899 james58899

Labels
status: wip This pr is working in progess system: block type: feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@james58899 @jimchen5209