fix build error with clang16 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please cite the actual build error message in the commit message? |
Sure |
With clang 16 I'm mainly getting these two errors and a warning:
1. src/olsrd_filtergw.c:186:7: error: call to undeclared function 'should_filter'; ISO C99 and
later do not support implicit function declarations [-Wimplicit-function-declaration]
if(!should_filter(&originator))
2. src/olsrd_filtergw.c:259:3: error: call to undeclared function 'olsr_parser_add_function';
ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
olsr_parser_add_function(&olsrd_filtergw_parser, HNA_MESSAGE);
3. src/olsrd_filtergw.c:273:26: warning: incompatible pointer types initializing
'struct filter_group *' with an expression of type 'struct hna_group *' [-Wincompatible-pointer-types]
struct filter_group* next = filter_groups->next;
This commit fixes all three of them.
Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With clang 16 I'm mainly getting these two errors and a warning:
src/olsrd_filtergw.c:186:7: error: call to undeclared function 'should_filter'; ISO C99 and
later do not support implicit function declarations [-Wimplicit-function-declaration]
if(!should_filter(&originator))
src/olsrd_filtergw.c:259:3: error: call to undeclared function 'olsr_parser_add_function';
ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
olsr_parser_add_function(&olsrd_filtergw_parser, HNA_MESSAGE);
src/olsrd_filtergw.c:273:26: warning: incompatible pointer types initializing
'struct filter_group *' with an expression of type 'struct hna_group ' [-Wincompatible-pointer-types]
struct filter_group next = filter_groups->next;
This commit fixes all three of them.