Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to opt in to downloading the songs instead of streaming #27

Open
Saad-Alareqi opened this issue Apr 9, 2023 · 2 comments
Open
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Saad-Alareqi
Copy link

Saad-Alareqi commented Apr 9, 2023

Hi,
As the title says. The music will play after 5 to 10 seconds and that's in my opinion isn't practical.
So my suggestion is to make your plugin download the music first time the user opens the game page in background. In this case the music will play instantly next times and also this will make the music also play when offline.

@OMGDuke
Copy link
Owner

OMGDuke commented Apr 9, 2023

5 to 10 seconds is much longer than I tend to see but that may have something to do with physical location/network speed.

The current way of getting the audio isn't perfect and it's something I'm improving upon here #23

In terms of downloads It's something I'm considering but it will have to come after some of the other tasks I'm working on

@OMGDuke OMGDuke changed the title Music delay Allow users to opt in to downloading the songs instead of streaming Apr 9, 2023
@OMGDuke OMGDuke added enhancement New feature or request help wanted Extra attention is needed labels Apr 9, 2023
@Saad-Alareqi
Copy link
Author

Saad-Alareqi commented Sep 12, 2023

It's not necessary to allow the user to download or make it visible to the user. You can cache the music in a hidden folder and make the plugin play the cached music offline if its available. Also this would save some bandwidth instead of streaming every time. I use the steam deck a lot while I'm out and without an internet connection, and I miss the music playing in background while offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants