-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make imports shortcuts #554
Conversation
This reverts commit 8469696.
Hey, @mimi030 |
Also, please, double check contribution pipeline & see how to update Readme |
And just to make sure we are on the same page: it's not necessary to simplify the imports inside the modules. I mean, you can do it, but the final purpose if to simplify examples, so, you can only simplify imports there. |
So just to clarify, should I focus only on updating the import statements in the examples found under Features Extraction? I'm feeling a bit confused about the task scope now, as I had understood from our discussion here that we were looking to implement these changes more broadly. To ensure I'm on the right track, could you please specify which specific files I should be targeting for these updates? Thank you for your guidance! |
Certainly! I've previously gone through the Contributing in general and Contributing to documentation, but I'll be happy to double-check everything again to ensure everything is in order. If you have specific areas or updates you'd like me to focus on, please let me know. |
from the guide:
|
Removing duplicates and preserving order in Accumulator
…ds in Accumulator Reworking datasets & interfaces * Introduced slightly different interfaces for datasets * Made a dedicated folder for images datasets. Renamed and moved old datasets. Kept names of the old dataset for backward compatibility. * Removed `ListDataset` Accumulator * Removing duplicates and preserving order in Accumulator
…zed kNN Introducing container for storing Retrieval Results and memory optimized kNN
Changelog: - Separated map, precision, cmc and fnmr and pfc metrics (there is no more single function that computes all of them) - Changed signature of the calc_retrieval_metrics (it works with the top k closest items instead of the full gallery) - Removed repeated calculations in EmbeddingMetrics when slicing over categories
Minor: improved type checking
Close because of: #535 (comment) |
**Amendments Overview:**
This pull request introduces the following improvements:
**Notes:**
By moving import statements into the corresponding modules' init.py files, most imports are simplified. A few import statements remain unchanged to prevent circular import issues.
Additionally, the import examples in the 'Features Extraction' documentation in Colab require permission to proceed, so they remain unchanged.