Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Country flag not showing in comments #1211

Closed
davehakkens opened this issue Sep 18, 2021 · 6 comments · Fixed by #1212
Closed

[bug] Country flag not showing in comments #1211

davehakkens opened this issue Sep 18, 2021 · 6 comments · Fixed by #1212

Comments

@davehakkens
Copy link
Contributor

davehakkens commented Sep 18, 2021

Describe the bug
The country flag of a user is not showing in the comments.
(example bottom of page)

Expected behavior
Flag should be shown like in this issue #1127
afbeelding

Screenshots
Possible problem mentioned by @tudi2d on Slack
Could this be the reason? (Image from the user page) For the addComment in the store it is only creatorCountry: user.country ? user.country.toLowerCase() : null saved to the backend.

afbeelding

@danitrod danitrod self-assigned this Sep 18, 2021
@danitrod
Copy link
Collaborator

Should be a quick one, I'll send a PR

@danitrod
Copy link
Collaborator

danitrod commented Oct 21, 2021

Reopening, as apparently the merged PR had no effect in the example page. We will have to further debug to find the root cause of this problem

@thisislawatts
Copy link
Collaborator

@danitrod there has not yet been a release to the production site. Have you been able to verify on the dev environment? It's a good idea to re-open this issue though until we've been able to manually verify on the production environment. Although an automated test that gives us confidence would also be helpful 🤔

@danitrod
Copy link
Collaborator

My bad @thisislawatts! Forgot that we had releases for a moment. For some reason the flags were already showing before this update in the dev environment, just in prod one not. I believe this is because of legacy users and how the location was stored differently. This PR should fix and now display flags for both legacy/new accounts. Let's see it the next release. But I definitely agree that an automated test would be the best way to go

@thisislawatts
Copy link
Collaborator

🎉 This issue has been resolved in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@davehakkens
Copy link
Contributor Author

closing this issue since new releases have made.
But the problem is still there: #1469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants