-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loading state to ImageGallery #3462
Comments
Hi, I haven't checked the code but what I've used in the past is the (somewhat) new See https://developer.mozilla.org/en-US/docs/Web/Performance/Lazy_loading#loading_attribute for more info |
FYI this is also quite bad for the user expereince in user-profiles. |
Looked into underlying issue and adding the lazy load itself is good for initial page load, which includes the smaller thumbnails and the larger resolution active image. That won't address larger issue of needing to tell browser to pre-load all of the larger resolution images for the non-active images, that way when swapping to them there won't be such a long delay. Alternative could be some sort of spinner/indicator when swapping images while the larger resolution image is loading. |
Thanks for looking into this @CubeLuke! I think a spinner is fine. Can I assign you the issue? |
Due to lazy loading (which we want to keep), there's a noticeable lag when selected a different image to show on the ImageGallery. Sometimes that gets picked up by our feature tests.
image-gall.mov
Please add some kind of loading state to the component - it's in the component library. This can then mean the step 'Step image is updated on thumbnail click' in
src/integration/howto/read.spec.ts
can be un-commented out.The text was updated successfully, but these errors were encountered: