Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[developer experience] make the theme picker on local development by default set to Precious Plastic #3546

Open
pizzaisdavid opened this issue May 14, 2024 · 0 comments

Comments

@pizzaisdavid
Copy link
Contributor

If you're a developer and want to tackle an issue related specifically to precious plastic might get a weird state: the website looks like Precious Plastic but the function isPreciousPlastic will return false.

On local development, this method internally uses a value stored locally in the browser but initially it isn't set.

For example, in Firefox, open http://localhost:3000/academy/intro.html in a private window, then open the storage tab, then click local storage, then click http://localhost:3000.

Only after explicitly selecting a theme is put into storage. This is hard to understand and might trip us new contributors.

initially:
image

after selecting Precious Plastic in the theme picker at the top:
image

ideally, on refresh, the theme picker would show which theme is select explicitly:
image

extra context:
here is a situation where it may have caused confusion: #3292 (comment)

@pizzaisdavid pizzaisdavid changed the title [developer improvement] make the theme picker on local development by default set to Precious Plastic [developer experience] make the theme picker on local development by default set to Precious Plastic May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New / Under Discussion
Development

No branches or pull requests

1 participant