Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restrict access to categories #3570

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

thisislawatts
Copy link
Collaborator

  • chore(ci): remove dependency on master
  • chore(ci): introduce approval step
  • feat: restrict access to categories

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

What this PR does

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

@thisislawatts thisislawatts force-pushed the feat/restrict-access-to-categories branch from e161674 to 51cb73f Compare May 21, 2024 19:40
@thisislawatts thisislawatts changed the title feat/restrict access to categories feat: restrict access to categories May 21, 2024
Copy link

cypress bot commented May 21, 2024

1 flaky test on run #5805 ↗︎

0 75 1 0 Flakiness 1

Details:

Merge branch 'master' into feat/restrict-access-to-categories
Project: onearmy-community-platform Commit: 10b98d0521
Status: Passed Duration: 04:27 💡
Started: Jun 14, 2024 11:35 AM Ended: Jun 14, 2024 11:40 AM
Flakiness  src/integration/howto/read.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
... > [See all info] Test Replay Screenshots Video

Review all test suite changes for PR #3570 ↗︎

@benfurber
Copy link
Member

@mariojsnunes Is this something you can pick-up?

@mariojsnunes mariojsnunes marked this pull request as ready for review June 14, 2024 11:54
@mariojsnunes mariojsnunes requested a review from a team as a code owner June 14, 2024 11:54
@mariojsnunes mariojsnunes merged commit 0573975 into master Jun 14, 2024
22 checks passed
@mariojsnunes mariojsnunes deleted the feat/restrict-access-to-categories branch June 14, 2024 11:54
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.191.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants