Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display research draft updates for author and admins #3586

Merged

Conversation

mariojsnunes
Copy link
Collaborator

@mariojsnunes mariojsnunes commented May 24, 2024

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

  • Considers the research item author and collaborators when filtering for draft/deleted updates. See: researchUpdateStatusFilter.
  • Adds tests for this filter.
  • Moves research helpers to their own file.

Git Issues

Fixes #3585

@mariojsnunes mariojsnunes requested a review from a team as a code owner May 24, 2024 05:10
Copy link

cypress bot commented May 24, 2024

Passing run #5802 ↗︎

0 76 1 0 Flakiness 0

Details:

fix: cypress tests
Project: onearmy-community-platform Commit: 96ce7440f7
Status: Passed Duration: 04:43 💡
Started: Jun 14, 2024 11:08 AM Ended: Jun 14, 2024 11:13 AM

Review all test suite changes for PR #3586 ↗︎

@benfurber
Copy link
Member

@mariojsnunes Can you please add some screenshots for the change.

@benfurber benfurber added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label May 28, 2024
Copy link
Contributor

github-actions bot commented May 28, 2024

Visit the preview URL for this PR (updated for commit 96ce744):

https://onearmy-next--pr3586-fix-display-research-erxt67ng.web.app

(expires Sun, 14 Jul 2024 12:46:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59

@mariojsnunes
Copy link
Collaborator Author

@mariojsnunes Can you please add some screenshots for the change.

video that shows the issue:

research.update.draft.mp4

as you can see, when you mark a research update as draft, you (the owner) can no longer see it.

This PR fixes this... makes it so the item author and collaborators can see it, but other users can't.

@benfurber
Copy link
Member

@mariojsnunes Got it, thanks. The cypress tests should definitely be updated then to show the fixed user flow for this please.

@benfurber benfurber added the 🤝 Awaiting author Waiting on action from the author label May 29, 2024
@mariojsnunes mariojsnunes deleted the fix/display-research-draft-updates branch June 13, 2024 10:02
@mariojsnunes mariojsnunes restored the fix/display-research-draft-updates branch June 13, 2024 11:12
@mariojsnunes mariojsnunes reopened this Jun 13, 2024
@mariojsnunes mariojsnunes changed the title fix: display research draft updates for author fix: display research draft updates for author and admins Jun 14, 2024
@mariojsnunes mariojsnunes merged commit c2c6fa2 into ONEARMY:master Jun 14, 2024
21 checks passed
@mariojsnunes mariojsnunes deleted the fix/display-research-draft-updates branch June 14, 2024 11:18
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.191.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤝 Awaiting author Waiting on action from the author Mod: Research 🔬 released Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[bug (research)] Research update drafts are not displaying for the author
3 participants