-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: display research draft updates for author and admins #3586
fix: display research draft updates for author and admins #3586
Conversation
Passing run #5802 ↗︎Details:
Review all test suite changes for PR #3586 ↗︎ |
@mariojsnunes Can you please add some screenshots for the change. |
Visit the preview URL for this PR (updated for commit 96ce744): https://onearmy-next--pr3586-fix-display-research-erxt67ng.web.app (expires Sun, 14 Jul 2024 12:46:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59 |
video that shows the issue: research.update.draft.mp4as you can see, when you mark a research update as draft, you (the owner) can no longer see it. This PR fixes this... makes it so the item author and collaborators can see it, but other users can't. |
@mariojsnunes Got it, thanks. The cypress tests should definitely be updated then to show the fixed user flow for this please. |
feat: also display drafts for admins;
🎉 This PR is included in version 1.191.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR Checklist
PR Type
Description
researchUpdateStatusFilter
.Git Issues
Fixes #3585