Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: research update edit #3772

Merged
merged 2 commits into from
Jul 14, 2024
Merged

fix: research update edit #3772

merged 2 commits into from
Jul 14, 2024

Conversation

mariojsnunes
Copy link
Collaborator

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix (fixes an issue)
  • Feature (adds functionality)
  • Code style update
  • Refactoring (no functional changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Clicking edit on a research update gives an error page to the user.

What is the new behavior?

Works as expected :)

Does this PR introduce a breaking change?

  • Yes
  • No

Git Issues

Closes #3771

What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

@mariojsnunes mariojsnunes merged commit 4ff3b6f into master Jul 14, 2024
20 checks passed
@mariojsnunes mariojsnunes deleted the fix/research-update-edit branch July 14, 2024 09:22
Copy link

cypress bot commented Jul 14, 2024

Passing run #6023 ↗︎

0 71 1 0 Flakiness 0

Details:

fix: edit delete redirect url
Project: onearmy-community-platform Commit: 25e6dba4dc
Status: Passed Duration: 04:06 💡
Started: Jul 14, 2024 9:19 AM Ended: Jul 14, 2024 9:23 AM

Review all test suite changes for PR #3772 ↗︎

@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.199.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[bug] Cannot edit a Research Module Update
2 participants