Update #1
Open
Update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a command with suppressed output failed, CommandFailedException would be raised with an emptry string as argument, which makes debugging issues really hard. In this cases we shall instantiate the exception with the same message passed to the log.
I found out these assertions were not being called while working on the previous commit.
Co-authored-by: Federico Capoano <f.capoano@openwisp.io>
Co-authored-by: Pedro Peña <pedro@makedit.com>
Tests were failing for sample app due to absence of openwisp_users.accounts in INSTALLED_APPS of test project settings.
Made notification tests to only check changes introduced in openwisp-controller.
- Minor changes to CI configuration to ensure correct version of Django in the Python environment. - Explicitly pin coverage<6.0 The pytest-cov lib doesn't cap the coverage version, breaking coveralls. - Reduced the number of queries in tests Co-authored-by: Federico Capoano <f.capoano@openwisp.io>
Device and DeviceGroup shall belong to the same organization.
Added Device, Config and DeviceConnection models to trigger deletion of obsolete notifications. Closes #557
Closes #324 Co-authored-by: Gagan Deep <pandafy.dev@gmail.com>
Closes #565 Co-authored-by: Gagan Deep <pandafy.dev@gmail.com>
The controller URL pattern used "uuid" converter which does not allow UUID hex code. Related to #551
The ConfigAdmin download URL pattern used "uuid" converter which does not allow UUID hex code. Related to #583
Closes #578 Co-authored-by: Federico Capoano <f.capoano@openwisp.io>
Co-authored-by: Gagan Deep <pandafy.dev@gmail.com>
Avoid manipulating private properties from Django.
…her #846 In PR #806, a unique_together constraint was added to the DeviceConnection model to ensure that adding more than one row with the same device_id and credentials_id in the database is not allowed. However, applying the migration may fail if the database already contains objects that contradict this unique constraint. To address this, we have added a data migration step to remove the conflicting objects from the database before applying the migration. Unfortunately this change may not be fully backward compatible for those who are using the development version, if you incur in any issue while running the migrations, you can fix this with: ./manage.py migrate --fake connection 0009 ./manage.py migrate Fixes #846 Co-authored-by: Federico Capoano <f.capoano@openwisp.io>
Base test classes were quite messed up. With this change, redundancy is reduced and it should be easier to read the base test methods.
Due to changes in the Django admin HTML, the form rows weren't hidden as expected. This patch should fix the issue and also be more robust to future Django upgrades. Added a selenium test.
Allow searching by name and/or mac address (case insensitive) in the device API list endpoint.
Bugs: - The "Send Command" operation was failing if the user defined command does not require an input. - The command.js was relying on presence of "reboot" default command. The JS would run into error in absence of the default "reboot" command and the loading overlay would not be hidden. This patch fixes the above mentioned bugs.
We should not use OpenwispCeleryTask class on celery tasks that queries over several objects in the database.
This task can take a long time to run, these changes will help to minimize run time and alleviate any pain if it still takes long to execute.
[skip ci]
Updates the requirements on [django-reversion](https://github.com/etianen/django-reversion) to permit the latest version. - [Release notes](https://github.com/etianen/django-reversion/releases) - [Changelog](https://github.com/etianen/django-reversion/blob/master/CHANGELOG.rst) - [Commits](etianen/django-reversion@v5.0.4...v5.0.12) --- updated-dependencies: - dependency-name: django-reversion dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
But only if installation of dependencies goes well.
Updates the requirements on [pytest-cov](https://github.com/pytest-dev/pytest-cov) to permit the latest version. - [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-cov@v4.1.0...v5.0.0) --- updated-dependencies: - dependency-name: pytest-cov dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [django-redis](https://github.com/jazzband/django-redis) to permit the latest version. - [Release notes](https://github.com/jazzband/django-redis/releases) - [Changelog](https://github.com/jazzband/django-redis/blob/master/CHANGELOG.rst) - [Commits](jazzband/django-redis@5.2.0...5.4.0) --- updated-dependencies: - dependency-name: django-redis dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updates the requirements on [netaddr](https://github.com/netaddr/netaddr) to permit the latest version. - [Release notes](https://github.com/netaddr/netaddr/releases) - [Changelog](https://github.com/netaddr/netaddr/blob/master/CHANGELOG.rst) - [Commits](netaddr/netaddr@0.8.0...1.3.0) --- updated-dependencies: - dependency-name: netaddr dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update netaddr requirement from ~=0.8.0 to ~=1.3.0 Updates the requirements on [netaddr](https://github.com/netaddr/netaddr) to permit the latest version. - [Release notes](https://github.com/netaddr/netaddr/releases) - [Changelog](https://github.com/netaddr/netaddr/blob/master/CHANGELOG.rst) - [Commits](netaddr/netaddr@0.8.0...1.3.0) --- updated-dependencies: - dependency-name: netaddr dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update pytest-asyncio requirement from ~=0.21.0 to ~=0.23.7 Updates the requirements on [pytest-asyncio](https://github.com/pytest-dev/pytest-asyncio) to permit the latest version. - [Release notes](https://github.com/pytest-dev/pytest-asyncio/releases) - [Commits](pytest-dev/pytest-asyncio@v0.21.0...v0.23.7) --- updated-dependencies: - dependency-name: pytest-asyncio dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.