Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set file limits via env-file #395

Open
xvybihal opened this issue Dec 8, 2021 · 3 comments
Open

Allow to set file limits via env-file #395

xvybihal opened this issue Dec 8, 2021 · 3 comments
Labels
feature request Issues that request new features to be added to OnlyOffice

Comments

@xvybihal
Copy link

xvybihal commented Dec 8, 2021

Do you want to request a feature or report a bug?
This is feature request.

What is the current behavior?
Currently the limits are hardcoded in container inside of conf files. For example /etc/onlyoffice/documentserver/default.json file.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
See #354 for suggestion how they can be changed.

What is the expected behavior?
My suggestion is to add the ability to set those limits via env-file, instead of mangling .conf and .json files inside of the container. I propose names:

NGINX_CLIENT_MAX_BODY_SIZE
MAX_FILE_SIZE
MAX_DOWNLOAD_BYTES
INPUT_LIMIT_UNCOMPRESSED_DOC
INPUT_LIMIT_UNCOMPRESSED_XLS
INPUT_LIMIT_UNCOMPRESSED_PPT

So the settings could be done using environment variables like this:

NGINX_CLIENT_MAX_BODY_SIZE=100M
MAX_FILE_SIZE=104857600
MAX_DOWNLOAD_BYTES=104857600
INPUT_LIMIT_UNCOMPRESSED_DOC=50MB
INPUT_LIMIT_UNCOMPRESSED_XLS=300MB
INPUT_LIMIT_UNCOMPRESSED_PPT=50MB
@ShockwaveNN
Copy link
Contributor

Thank you for your idea

I've created issue 54440 in our private issue tracker to discuss this feature with our team

@ShockwaveNN ShockwaveNN added the feature request Issues that request new features to be added to OnlyOffice label Dec 8, 2021
@ololukaszuk
Copy link

ololukaszuk commented Jul 31, 2022

Hi, just finished with my solution to this.
Check it out, please.
https://hub.docker.com/repository/docker/alexwoo42/documentserver-ee/general

Dockerfile:
Dockerfile.txt

run-document-server.sh:
run-document-server.sh.txt

@ScionOfDesign
Copy link

Hi, just finished with my solution to this. Check it out, please. https://hub.docker.com/repository/docker/alexwoo42/documentserver-ee/general

Dockerfile: Dockerfile.txt

run-document-server.sh: run-document-server.sh.txt

Thank you! This saves me a lot of annoying work. I hope this issue gets resolved soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to OnlyOffice
Projects
None yet
Development

No branches or pull requests

4 participants