Feature/add change area overlay - ticket#135 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts to change area on map on categoryId/locations/locationId route
|
✔️ Deploy Preview for ons-data-map ready! 🔨 Explore the source changes: e9fa528 🔍 Inspect the deploy log: https://app.netlify.com/sites/ons-data-map/deploys/61e010e797409f0008d4a312 😎 Browse the preview: https://deploy-preview-78--ons-data-map.netlify.app |
|
Blocked by ONSdigital/design-system#1761 (comment) |
|
Fix incoming in ONSdigital/design-system#1798 |
vmilitaru
changed the title
…routes/area/index.svelte pages to toggle the header when the user wants to update the location
…s/area/index.svelte page
…s/[topicSlug]/[tableSlug]/[categorySlug].svelte page
…aHeader component
… routes/[topicSlug]/[tableSlug]/[categorySlug].svelte to display the change
…reaComponent error panel
…mponent error panel
…/[categorySlug].svelte screen
Closed
|
Now unblocked. |
mwnicks
reviewed
Jan 11, 2022
mwnicks
reviewed
Jan 12, 2022
…pecific to the selected geography
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I have added the logic to toggle the header on Explore by Location (Walsall) and Explore by Category & Location screens when a user wants to search for a different location.
I haven't added the styling, I leave this with you @designorant because when I am trying to use a position on the header everything moves around the page...
Note: The js does not load on the
<ONSAutosuggest/>component on anon:clickevent because at the moment we can only load the ons DS js at a page level not at a component level and we hope that this will go away once the issue is fixed by the design system team.