Skip to content

Commit

Permalink
Updated the endpoint
Browse files Browse the repository at this point in the history
  • Loading branch information
jitendar committed Feb 24, 2023
1 parent ad098b4 commit e11f079
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
6 changes: 4 additions & 2 deletions api/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ func New(_ context.Context, cfg *config.Config, r chi.Router, idc *identity.Clie

func (api *API) enablePublicEndpoints() {
api.Router.Post("/filters", api.createFilter)
api.Router.Post("/filters/custom", api.createCustomFilter)
api.Router.Get("/filters/{id}", api.getFilter)
api.Router.Put("/filters/{id}", api.putFilter)
api.Router.Post("/filters/{id}/submit", api.submitFilter)
Expand All @@ -81,6 +80,8 @@ func (api *API) enablePublicEndpoints() {
api.Router.Put("/filter-outputs/{id}", api.putFilterOutput)

api.Router.Get("/datasets/{dataset_id}/editions/{edition}/versions/{version}/json", api.getDatasetJSONHandler)

api.Router.Post("/custom/filters", api.createCustomFilter)
}

func (api *API) enablePrivateEndpoints() {
Expand All @@ -94,7 +95,6 @@ func (api *API) enablePrivateEndpoints() {
r.Use(permissions.Require(auth.Permissions{Read: true}))

r.Post("/filters", api.createFilter)
r.Post("/filters/custom", api.createCustomFilter)
r.Get("/filters/{id}", api.getFilter)
r.Put("/filters/{id}", api.putFilter)
r.Post("/filters/{id}/submit", api.submitFilter)
Expand All @@ -116,5 +116,7 @@ func (api *API) enablePrivateEndpoints() {

r.Get("/datasets/{dataset_id}/editions/{edition}/versions/{version}/json", api.getDatasetJSONHandler)

r.Post("/custom/filters", api.createCustomFilter)

api.Router.Mount("/", r)
}
8 changes: 4 additions & 4 deletions features/create_custom_filter.feature
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ Feature: Filters Private Endpoints Not Enabled
}
"""

When I POST "/filters/custom"
When I POST "/custom/filters"
"""
{
"population_type": "Example"
Expand Down Expand Up @@ -273,7 +273,7 @@ Feature: Filters Private Endpoints Not Enabled
}
"""

When I POST "/filters/custom"
When I POST "/custom/filters"
"""
{
"population_type": "Example"
Expand Down Expand Up @@ -303,7 +303,7 @@ Feature: Filters Private Endpoints Not Enabled
}
"""

When I POST "/filters/custom"
When I POST "/custom/filters"
"""
{
"population_type": "Example"
Expand All @@ -323,7 +323,7 @@ Feature: Filters Private Endpoints Not Enabled

Scenario: Creating a new filter bad request body

When I POST "/filters/custom"
When I POST "/custom/filters"
"""
"""

Expand Down

0 comments on commit e11f079

Please sign in to comment.