feat: default categorisation change #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrysmOre
reviewed
Jan 18, 2023
saminahbab
force-pushed
the
patch/defaul-cat-failure-case
branch
from
3718d71
to
43303e7
Compare
saminahbab
commented
Jan 19, 2023
saminahbab
force-pushed
the
patch/defaul-cat-failure-case
branch
from
43303e7
to
a53d065
Compare
ChrysmOre
reviewed
Jan 20, 2023
saminahbab
force-pushed
the
patch/defaul-cat-failure-case
branch
2 times, most recently
from
890df53
to
e658809
Compare
j-s-rawat
reviewed
Jan 23, 2023
| // RetrieveDefaultCategorisation takes dimension, returns categorisations, and checks if any are default. | ||
| // if so, it returns the relevant information. If there are no default categorisations, it returns empty string | ||
| // for default categorisation, and the original dimension name and label to persist instead. | ||
| func (api *API) RetrieveDefaultCategorisation(dimension *model.Dimension, datasetName string) (string, string, string, error) { |
There was a problem hiding this comment.
Preference for return will be either to introduce a struct or named return variables. Function signature is not obvious enough to explain what these 3 returned strings are
There was a problem hiding this comment.
I think the named variables add too many extra lines of code, and a struct feels overkill for just one function, @j-s-rawat can I just add a comment that explains the return signature?
There was a problem hiding this comment.
To be honest this seems like a bit of a code smell that the function is trying to do too much. It may be better to split it up into two (or more).
There was a problem hiding this comment.
given the need for the changes soon, this will be dealt with in a future refactor
saminahbab
force-pushed
the
patch/defaul-cat-failure-case
branch
from
e658809
to
108191d
Compare
ChrysmOre
reviewed
Jan 24, 2023
ChrysmOre
reviewed
Jan 24, 2023
saminahbab
force-pushed
the
patch/defaul-cat-failure-case
branch
3 times, most recently
from
a6629df
to
7ed524f
Compare
ChrysmOre
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Describe what you have changed and why.
How to review
Describe the steps required to test the changes.
Who can review
Describe who worked on the changes, so that other people can review.