Feature/fix geog dimension metadata #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrysmOre
reviewed
Jan 10, 2023
| break | ||
| } | ||
| } | ||
|
|
||
| if !areaTypeFound { | ||
| areaTypeDimension := []dataset.VersionDimension{ |
There was a problem hiding this comment.
Does this need to be a slice?
ChrysmOre
reviewed
Jan 10, 2023
| for _, d := range m.Version.Dimensions { | ||
| if *d.IsAreaType { | ||
| d.Label = areaTypeLabel | ||
| d.Description = areaTypeDescription | ||
| d.ID = areaTypeId |
There was a problem hiding this comment.
Are you 100% sure this is working as expected? I'd half expect this not to update the dimensions of the original struct you're trying to, I might be wrong though.
ChrysmOre
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix for updated geography dimension not being added to metadata on filtered dataset
This fix is to address the issue with the original PR for this ticket (#62), which when tested in sandbox was still not pulling through the updated geography dimension in the csvw and txt metadata files
Trello - https://trello.com/c/MGF4L4rT/5950-get-meta-data-for-area-type-selection-to-show-on-custom-data-set-output-files
How to review
Confirm changes make sense and match requested changes in Trello ticket
Who can review
Anyone