add second (and legacy) kafka consumer if env vars for it differ #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshumoogum
suggested changes
Sep 6, 2021
README.md
Outdated
| | KAFKA_LEGACY_VERSION | `1.0.2` | The version of Kafka - non-TLS | ||
| | KAFKA_ADDR | `localhost:9092` | The addresses of the kafka brokers (CSV) | ||
| | KAFKA_VERSION | `1.0.2` | The version of Kafka | ||
| | KAFKA_SEC_PROTO | _unset_ | if set to `TLS`, kafka connections will use TLS [1] |
There was a problem hiding this comment.
Maybe link [1] to notes bullet point 1 - not necessarily obvious why this is here unless you review PR or look at code changes
There was a problem hiding this comment.
You can use this as a reference (ONSdigital/dp-dimension-search-api#89). This was reviewed by Nathan and approved
There was a problem hiding this comment.
Thanks Justin - yes I was thinking of the same changes made here
There was a problem hiding this comment.
my markdown linter complains about inline-HTML for your method, so I prefer my method 😛
(frankly, I think if people don't understand the original footnote syntax, then 🤷 but here we are...)
gedge
force-pushed
the
feature/kafka-msk-ready
branch
from
9531a93
to
c00d57f
Compare
nshumoogum
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
(currently feature-flagged off in secrets)
add a second kafka consumer where secrets determine a second (differing) kafka server address
add TLS to kafka consumer, if requested
How to review
test with features off
Who can review
!gedge