Feature/update shared components #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-nick17
force-pushed
the
feature/update-shared-components
branch
from
4b34d72
to
95966db
Compare
mr-nick17
commented
Apr 21, 2023
lindenmckenzie
previously approved these changes
Apr 25, 2023
lindenmckenzie
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Note this PR contains breaking changes, before merging and releasing a v1 branch will be created for any required maintenance
<main>element; an accessibility requirement. Any consuming apps will need to remove the partial reference from their templates. Breadcrumbs should continue to render as currently after removal from consuming service.dp-frontend-release-calendar). Updated existing<input>templates, consolidatedmodelinto one file (model.go) to avoid repetition and removed service specific model binding (a breaking change) and moved files to a common location.inputsto adopt a standardised approach of implementation and field validation. Fields created:<input><textarea>input<fieldset>readmewith new fields and updated design system URLsHow to review
Sense check
Happy to demo any of the above ⬆️
Who can review
Frontend go dev