Ensure placeholders with and without context are found correctly #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwootten
changed the title
iwootten
changed the title
bambrp
approved these changes
May 28, 2019
iwootten
force-pushed
the
eq-3025-fix-placeholder-translation
branch
from
c67d72a
to
4262fca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
The previous placeholder extraction wrongly assumed that placeholders would never require context (i.e Be part of an answer). This change seeks to correct that.
Instead of searching for placeholders using the 'text' key as part of a no_context key search, it searches for placeholders and filters them into separate lists dependant on whether they require context.
How to review?
The new unit test (taken from census individual) includes keys that require both context and don't so should now cover both use cases. See if you agree with the approach.