Tolerate int32 value in database when reading into an int64 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The graphson payload that represent int64 and int32 typed values from the database, is a map that contains a string representation of the type, and a separate value field.
The existing code for reading an int64 requires that this string representation of the type is g:Int42.
This change relaxes that requirement to tolerate also the string being g:Int64.
This use case was discovered by a client wishing to de-serialize such a payload into a structure with an int64 field. The value had been created in the database using a neptune query that set an integer property with an integer constant value, where it is impossible to force it to be made as an int64.