Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Special requierements check" criteria has closing tags for subgroups on the same levels in taxonomy #interproc #371

Closed
JustinaZaltauskaite opened this issue Jan 9, 2023 · 5 comments

Comments

@JustinaZaltauskaite
Copy link

"Special requierements check" criteria has closing tags for QUESTION_SUBGROUP on the same levels in taxonomy, although one of the group is inside the other.
At first glance looks like an indentation issue, but maybe something is missing

image

@delgajc
Copy link
Contributor

delgajc commented Jan 10, 2023

Good afternoon,
Thank you very much for your comment.

The reported indentation issue has been fixed in release v3.1.0.

Kind regards,
The ESPD Team

@delgajc delgajc closed this as completed Jan 10, 2023
@JustinaZaltauskaite
Copy link
Author

@delgajc Checked if I had the newest version of taxonomy for 3.1.0 - and yes the one was from 3.1.0
So, Issue still exists
Downloaded taxonomy from https://github.com/OP-TED/ESPD-EDM/blob/master/codelists/ESPD-criterion.xlsx on 2023/01/10
image

@delgajc delgajc reopened this Jan 13, 2023
delgajc added a commit that referenced this issue Jan 13, 2023
@delgajc
Copy link
Contributor

delgajc commented Jan 13, 2023

Good afternoon,
apologies, you are right, this fix was not included in release 3.1.0. It's now fixed in the Excel file and you can find it here.

Kind Regards,
The ESPD Team.

@delgajc delgajc closed this as completed Jan 13, 2023
@JustinaZaltauskaite
Copy link
Author

@delgajc any ideas when all newest fixes will be released (merged into main) officially?

delgajc added a commit that referenced this issue Jan 19, 2023
@delgajc
Copy link
Contributor

delgajc commented Jan 19, 2023

Good afternoon,
this fix will be included in the upcoming major release 4.0.0 we are working on.

Kind Regards,
The ESDP Team.

@delgajc delgajc reopened this Jan 23, 2023
delgajc added a commit that referenced this issue Jan 23, 2023
@delgajc delgajc closed this as completed Jan 23, 2023
pascalinelaur added a commit that referenced this issue Aug 14, 2023
Fix #369 TEDSPD-506, Fix #371 TEDSPD-509
new uuid
misplacement : closing QSG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants