-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download Rust Toolchain during "make toolchains" on aarch64 hosts #748
Download Rust Toolchain during "make toolchains" on aarch64 hosts #748
Conversation
9482459
to
2ce4742
Compare
@jforissier I have made the change you suggested and force-pushed. I was thinking that was the better way to do it, but I also wanted to submit something with minimal impact. That was the main reason I marked the PR as "DRAFT". I've removed draft and the PR is ready for review. The other reason I left it as "DRAFT" is because the build still fails on aarch64, but I think that can be addressed in a separate PR as this one does allow the build to get further than it did before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
|
@jforissier Is there anything else I need to do to help get this merged? Does it need additional review? Should I rebase on |
@msgilligan no need to rebase, it is done automatically by GitHub. However please add the |
Signed-off-by: Sean Gilligan <sean@msgilligan.com> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
2ce4742
to
4c5d2d5
Compare
Thanks for reminding me! Done! |
This is a
draftPRthat attemptsto fix Issue #749Note that with this patch the build still fails when actually using the Rust toolchain. It seems to be a linker configuration issue. This is one of the error messages I'm getting: