Simplify CMake library version declarations and configure include_directories for BUILD_INTERFACE and INSTALL_INTERFACE #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting in the version in the `project()` call automatically populates the variables `PROJECT_VERSION_MAJOR`, `_MINOR`, `_PATCH` and `_TWEAK` (if used). If a `SHARED` version of `ckteec` is built, `PROJECT_VERSION_MAJOR` can be used for the `SOVERSION`. Signed-off-by: Eero Aaltonen <eero.aaltonen@vaisala.com> Acked-by: Jerome Forissier <jerome@forissier.org> Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
|
@etienne-lms: FYI I squashed the fixup (refresh) commits, but kept your |
|
For commit "Remove setting include_directory for teec": do you mean
|
eaaltonen
force-pushed
the
cmake-fixes
branch
2 times, most recently
from
775b233
to
42e1797
Compare
Re-phrased to
And also added Acked-by. |
|
Would you mind adding a |
Seems to be unused, and CMake builds are easier to reason about, if each subdirectory only configures targets located within itself. Signed-off-by: Eero Aaltonen <eero.aaltonen@vaisala.com> Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
A separate generator expression allows to refer to the headers from the same build tree. Signed-off-by: Eero Aaltonen <eero.aaltonen@vaisala.com> Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Not at all; and done. As long as you don't mind the slightly longer summary line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two CMake fix commits originally from the start of #259 (stale).
These don't depend on
libuuid, so can be brought in before those changes.Refreshed with fixup commits for changes since last year.