Eliminate duplicate endpoints when Configured base addresses differ b…

…y port only
OPCFoundation · Jan 27, 2022 · f9a6509 · f9a6509
1 parent ac13151
commit f9a6509
Showing 1 changed file with 7 additions and 15 deletions.
diff --git a/Stack/Opc.Ua.Core/Stack/Server/ServerBase.cs b/Stack/Opc.Ua.Core/Stack/Server/ServerBase.cs
@@ -1075,6 +1075,12 @@ private static string GetBestDiscoveryUrl(Uri clientUrl, BaseAddress baseAddress
                         continue;
                     }
 
+                    if (endpointUrl.Port != baseAddress.Url.Port)
+                    {
+                        continue;
+                    }
+
+
                     EndpointDescription translation = new EndpointDescription();
 
                     translation.EndpointUrl = baseAddress.Url.ToString();
@@ -1094,22 +1100,8 @@ private static string GetBestDiscoveryUrl(Uri clientUrl, BaseAddress baseAddress
                     translation.UserIdentityTokens = endpoint.UserIdentityTokens;
                     translation.Server = application;
 
-                    // skip duplicates.
-                    bool duplicateFound = false;
+                    translations.Add(translation);
 
-                    foreach (EndpointDescription existingTranslation in translations)
-                    {
-                        if (existingTranslation.IsEqual(translation))
-                        {
-                            duplicateFound = true;
-                            break;
-                        }
-                    }
-
-                    if (!duplicateFound)
-                    {
-                        translations.Add(translation);
-                    }
                 }
             }