Skip to content

Commit

Permalink
Modelcompiler 2021 11 24 (Fixes for MethodDeclarationId) (#1612)
Browse files Browse the repository at this point in the history
- ModelCompiler Fixes for MethodDeclarationId
- Previous fix not only removed TypDefinitionId in certain cases but also removed the MethodDeclarationId
- This backward compatible fix should work with old and new nodeset files
  • Loading branch information
opcfoundation-org committed Nov 24, 2021
1 parent 486e97b commit fdf31dc
Show file tree
Hide file tree
Showing 13 changed files with 5,311 additions and 4,361 deletions.
2 changes: 1 addition & 1 deletion Stack/Opc.Ua.Core/Schema/NodeIds.csv
Original file line number Diff line number Diff line change
Expand Up @@ -8043,7 +8043,7 @@ DiscrepancyAlarmType_Tolerance,17217,Variable
SafetyConditionClassType,17218,ObjectType
HighlyManagedAlarmConditionClassType,17219,ObjectType
TrainingConditionClassType,17220,ObjectType
TestingConditionSubClassType,17221,ObjectType
TestingConditionClassType,17221,ObjectType
AuditConditionCommentEventType_ConditionEventId,17222,Variable
AuditConditionAcknowledgeEventType_ConditionEventId,17223,Variable
AuditConditionConfirmEventType_ConditionEventId,17224,Variable
Expand Down
960 changes: 756 additions & 204 deletions Stack/Opc.Ua.Core/Schema/Opc.Ua.NodeSet2.xml

Large diffs are not rendered by default.

25 changes: 19 additions & 6 deletions Stack/Opc.Ua.Core/Schema/UANodeSet.cs
Original file line number Diff line number Diff line change
Expand Up @@ -151,16 +151,18 @@ public partial class ModelTableEntry {

private string modelUriField;

private string xmlSchemaUriField;

private string versionField;

private System.DateTime publicationDateField;

private bool publicationDateFieldSpecified;

private byte accessRestrictionsField;
private ushort accessRestrictionsField;

public ModelTableEntry() {
this.accessRestrictionsField = ((byte)(0));
this.accessRestrictionsField = ((ushort)(0));
}

/// <remarks/>
Expand Down Expand Up @@ -196,6 +198,17 @@ public partial class ModelTableEntry {
}
}

/// <remarks/>
[System.Xml.Serialization.XmlAttributeAttribute()]
public string XmlSchemaUri {
get {
return this.xmlSchemaUriField;
}
set {
this.xmlSchemaUriField = value;
}
}

/// <remarks/>
[System.Xml.Serialization.XmlAttributeAttribute()]
public string Version {
Expand Down Expand Up @@ -231,8 +244,8 @@ public partial class ModelTableEntry {

/// <remarks/>
[System.Xml.Serialization.XmlAttributeAttribute()]
[System.ComponentModel.DefaultValueAttribute(typeof(byte), "0")]
public byte AccessRestrictions {
[System.ComponentModel.DefaultValueAttribute(typeof(ushort), "0")]
public ushort AccessRestrictions {
get {
return this.accessRestrictionsField;
}
Expand Down Expand Up @@ -918,7 +931,7 @@ public partial class UANode {

private uint userWriteMaskField;

private byte accessRestrictionsField;
private ushort accessRestrictionsField;

private bool accessRestrictionsFieldSpecified;

Expand Down Expand Up @@ -1059,7 +1072,7 @@ public partial class UANode {

/// <remarks/>
[System.Xml.Serialization.XmlAttributeAttribute()]
public byte AccessRestrictions {
public ushort AccessRestrictions {
get {
return this.accessRestrictionsField;
}
Expand Down
3 changes: 2 additions & 1 deletion Stack/Opc.Ua.Core/Schema/UANodeSet.xsd
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@
<xs:element name="RequiredModel" type="ModelTableEntry" minOccurs="0" maxOccurs="unbounded" />
</xs:sequence>
<xs:attribute name="ModelUri" type="xs:string" use="required" />
<xs:attribute name="XmlSchemaUri" type="xs:string" use="optional" />
<xs:attribute name="Version" type="xs:string" />
<xs:attribute name="PublicationDate" type="xs:dateTime" />
<xs:attribute name="AccessRestrictions" type="AccessRestriction" default="0" />
Expand Down Expand Up @@ -215,7 +216,7 @@
</xs:simpleType>

<xs:simpleType name="AccessRestriction">
<xs:restriction base="xs:unsignedByte" />
<xs:restriction base="xs:unsignedShort" />
</xs:simpleType>

<xs:simpleType name="ArrayDimensions">
Expand Down
8,243 changes: 4,117 additions & 4,126 deletions Stack/Opc.Ua.Core/Stack/Generated/Opc.Ua.Classes.cs

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions Stack/Opc.Ua.Core/Stack/Generated/Opc.Ua.Constants.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11380,9 +11380,9 @@ public static partial class ObjectTypes
public const uint StatisticalConditionClassType = 18665;

/// <summary>
/// The identifier for the TestingConditionSubClassType ObjectType.
/// The identifier for the TestingConditionClassType ObjectType.
/// </summary>
public const uint TestingConditionSubClassType = 17221;
public const uint TestingConditionClassType = 17221;

/// <summary>
/// The identifier for the AuditConditionEventType ObjectType.
Expand Down Expand Up @@ -47600,9 +47600,9 @@ public static partial class ObjectTypeIds
public static readonly NodeId StatisticalConditionClassType = new NodeId(Opc.Ua.ObjectTypes.StatisticalConditionClassType);

/// <summary>
/// The identifier for the TestingConditionSubClassType ObjectType.
/// The identifier for the TestingConditionClassType ObjectType.
/// </summary>
public static readonly NodeId TestingConditionSubClassType = new NodeId(Opc.Ua.ObjectTypes.TestingConditionSubClassType);
public static readonly NodeId TestingConditionClassType = new NodeId(Opc.Ua.ObjectTypes.TestingConditionClassType);

/// <summary>
/// The identifier for the AuditConditionEventType ObjectType.
Expand Down Expand Up @@ -79289,9 +79289,9 @@ public static partial class BrowseNames
public const string TemporaryFileTransferType = "TemporaryFileTransferType";

/// <summary>
/// The BrowseName for the TestingConditionSubClassType component.
/// The BrowseName for the TestingConditionClassType component.
/// </summary>
public const string TestingConditionSubClassType = "TestingConditionSubClassType";
public const string TestingConditionClassType = "TestingConditionClassType";

/// <summary>
/// The BrowseName for the ThreeDCartesianCoordinates component.
Expand Down
Binary file modified Stack/Opc.Ua.Core/Stack/Generated/Opc.Ua.PredefinedNodes.uanodes
Binary file not shown.

0 comments on commit fdf31dc

Please sign in to comment.