Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server/ServerCapabilities/OperationLimits properties are set to invalid values (0). #1363

Closed
Zigby opened this issue Apr 15, 2021 · 0 comments · Fixed by #1434
Closed

Server/ServerCapabilities/OperationLimits properties are set to invalid values (0). #1363

Zigby opened this issue Apr 15, 2021 · 0 comments · Fixed by #1434
Assignees
@mregen
Labels
bug A bug was identified and should be fixed. compliance An issue was found which is not compliant with the OPC UA specification.
Milestone
1.4.367

Comments

@Zigby
Copy link
Contributor

Zigby commented Apr 15, 2021

Type of Issue
Bug

Describe the Issue
The ReferenceServer provided in UA-.NETStandard is providing invalid values (0) for the ServerCapabilities properties.
From what I can read from the specification the value should be non-zero:
"Any operational limits Property that is provided shall have a non zero value."
https://reference.opcfoundation.org/v104/Core/docs/Part5/6.3.11/

To Reproduce
Steps to reproduce the behavior:

  1. Compile the ReferenceServer
  2. Connect to ReferenceServer
  3. Browse Address space to the Server/ServerCapabilities/OperationLimits'
  4. Read/Subscribe to the OperationLimit properties
  5. Value is zero,

Expected behavior
Non-zero values should be provided if the optional properties are provided in the address space.
I would expect these OperationsLimits to be configurable in the Config.xml file.
It is however possible to set these values programatically as a workaround, but I was assuming it would be a good idea to add the Operations Limits to the the ServerConfiguration?
Also it seems the ReferenceServer is not complient in this regards?

Environment

  • Component: Opc.Ua.Server]
  • Server: Reference Server
  • Client: e.g UA Expert
@mregen mregen added compliance An issue was found which is not compliant with the OPC UA specification. needs investigation labels May 3, 2021
@mregen mregen self-assigned this Jun 26, 2021
@mregen mregen mentioned this issue Jun 26, 2021
Merged
@mregen mregen added bug A bug was identified and should be fixed. and removed needs investigation labels Jun 27, 2021
mregen added a commit that referenced this issue Jul 6, 2021
@mregen
Create client and server test projects, increase test coverage (#1434)
0236d08 
- Add Operation limit parameter and fix server. Fixes #1363 
- Add client/server test projects
- Add client and server fixture for test runs
- Server tests can test services without client connection
- Client tests can use common services to write tests which can run directly on server on via client server connection
- Increase code coverage > 50%
- Code coverage excludes the generated code
- Improve codecoverage local tests with report (see Tests/codecoverage scripts)
- Add a benchmark framework to client server tests
@mregen mregen added this to the 1.4.367 milestone Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mregen mregen

Labels
bug A bug was identified and should be fixed. compliance An issue was found which is not compliant with the OPC UA specification.
Projects
None yet
Milestone
1.4.367
Development

Successfully merging a pull request may close this issue.

Create client and server test projects, increase test coverage mregen/UA-.NetStandardLibrary
2 participants
@mregen @Zigby