Set TypeId for structured types at decode. #1260
Conversation
There was a problem hiding this comment.
I don't see functional changes when the new parameter is not used, so this is ok.
But the interface change causes a build error if not being addressed, so version json should be bumped to 366 due to the interface change. Please add it, then its all fine.
-- just some head scratching. If it can be recompiled to the new libs without change we can stick with 365...
| /// <param name="systemType">The system type of the encopdeable object to be read</param> | ||
| /// <param name="encodeableTypeId">The TypeId for the <see cref="IEncodeable"/> instance that will be read.</param> | ||
| /// <returns>An <see cref="IEncodeable"/> object that was read from the stream.</returns> | ||
| IEncodeable ReadEncodeable(string fieldName, System.Type systemType, ExpandedNodeId encodeableTypeId = null); |
There was a problem hiding this comment.
looks like a breaking change to IDecoder interface. We need to bump up version json to 366.
There was a problem hiding this comment.
or is a caller able to consume it without code change? Then we can stick with 365
There was a problem hiding this comment.
It should be no breaking change since since default value is set encodeableTypeId = null.
There was a problem hiding this comment.
@AlinMoldovean, then it looks good to me.
No description provided.