Add Serilog sample to ref servers #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mregen
commented
Jan 28, 2021
mregen
commented
- the Serilog trace event logger replaces the default log output file
- optional logging to console / debug
Codecov Report
@@ Coverage Diff @@
## master #1263 +/- ##
=========================================
Coverage ? 41.80%
=========================================
Files ? 289
Lines ? 104934
Branches ? 0
=========================================
Hits ? 43868
Misses ? 61066
Partials ? 0 Continue to review full report at Codecov.
|
mregen
commented
Jan 29, 2021
mregen
commented
Jan 29, 2021
mregen
commented
Jan 29, 2021
koepalex
reviewed
Jan 29, 2021
| if (lastContact) | ||
| { | ||
| item += String.Format("Last Event:{0:HH:mm:ss}", session.SessionDiagnostics.ClientLastContactTime.ToLocalTime()); | ||
| item += string.Format("Last Event:{0:HH:mm:ss}", session.SessionDiagnostics.ClientLastContactTime.ToLocalTime()); |
There was a problem hiding this comment.
it is better to use StringBuilder instead of string concatenation by +=
AlinMoldovean
approved these changes
Feb 1, 2021
fremat
pushed a commit
to fremat/UA-.NETStandard
that referenced
this pull request
Feb 10, 2021
- the Serilog trace event logger replaces the default log output file - optional logging to console / debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.