Fix issue setting empty comments Issue 1264 #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Acknowledge and Confirm, if a comment with an empty Locale and empty Text is passed from the client, then the comment should remain untouched. Also fixed issue when firing an event, clearing the change mask on all children of the alarm will update any monitored item watching the alarm parameters, like Comment, EventId, etc.
|
|
mregen
approved these changes
Jan 29, 2021
|
|
||
| /// <summary> | ||
| /// Determines if a comment should be added on Acknowledgement or Confirm. | ||
| /// According to the specification for Alarms, the Acknowledgement states that |
There was a problem hiding this comment.
the explaining comment might be better under <remarks>?
There was a problem hiding this comment.
Documentation updated as requested
AlinMoldovean
approved these changes
Jan 29, 2021
|
Hi @Archie-Miller let me know if you want to address that comment feedback, otherwise we call it a merge... |
fremat
pushed a commit
to fremat/UA-.NETStandard
that referenced
this pull request
Feb 10, 2021
…ion#1265) * Fix issue setting empty comments On Acknowledge and Confirm, if a comment with an empty Locale and empty Text is passed from the client, then the comment should remain untouched. Also fixed issue when firing an event, clearing the change mask on all children of the alarm will update any monitored item watching the alarm parameters, like Comment, EventId, etc. fixes OPCFoundation#1264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue 1264
On Acknowledge and Confirm, if a comment with an empty Locale and empty Text is passed from the client, then the comment should remain untouched.
Also fixed issue when firing an event, clearing the change mask on all children of the alarm will update any monitored item watching the alarm parameters, like Comment, EventId, etc.