Proper TPL usage and dependency injection for ConsoleReferenceClient #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se, and uses string interpolation versus String.Format.
AlinMoldovean
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make sure that anybody looking at the sample applications see proper TPL usage. Things like
Taskfor methods that do asynchronous workAsyncon methods that returnTask.GetAwaiter().GetResult()instead ofWaitorResultI also decoupled dependencies to Console and response validation and passed those concepts in through constructor injection. Showing examples of creating more complicated things through composition instead of having tightly coupled dependencies.
Lastly I refactored the usage of String.Format to use string interpolation instead.