fix commands and .NET-version in README #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix required .NET-Version to 3.1 fix dotnet restore command to be compatible to bash fix pathes of ReferenceServer (delete NetCore from path)
|
|
update changes according to MR OPCFoundation#1285
There was a problem hiding this comment.
@linderd ,
.NET Core 2.1 is required for Visual Studio 2017 and 3.1 is required only for Visual Studio 2019
Could you adapt the text with this?
target.props contains:
<Project>
<Choose>
<When Condition="'$(VisualStudioVersion)' == '16.0'">
<PropertyGroup>
<AppTargetFrameworks>net462;netcoreapp3.1</AppTargetFrameworks>
<AppTargetFramework>netcoreapp3.1</AppTargetFramework>
<TestsTargetFrameworks>net462;netcoreapp2.1;netcoreapp3.1</TestsTargetFrameworks>
<LibTargetFrameworks>net462;netstandard2.0;netstandard2.1</LibTargetFrameworks>
<LibxTargetFrameworks>net462;netcoreapp2.1;netstandard2.1</LibxTargetFrameworks>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup>
<AppTargetFrameworks>net462;netcoreapp2.1</AppTargetFrameworks>
<AppTargetFramework>netcoreapp2.1</AppTargetFramework>
<TestsTargetFrameworks>netcoreapp2.1</TestsTargetFrameworks>
<LibTargetFrameworks>net462;netstandard2.0</LibTargetFrameworks>
<LibxTargetFrameworks>net462;netcoreapp2.1</LibxTargetFrameworks>
</PropertyGroup>
</Otherwise>
</Choose>
</Project>
add .NET-Core 2.1 for Visual Studio 2017 add .NET-Core 3.1 for Visual Studio 2019
AlinMoldovean
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the .NET-Version in README is outdated, the pathes for reference-server are not existing anymore, so I fixed this:
fix required .NET-Version to 3.1
fix dotnet restore command to be compatible to bash (add ' )
fix pathes of ReferenceServer (update NetCore to Console in path)