Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interface for NodeCache #1364

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Add interface for NodeCache #1364

merged 2 commits into from
Apr 16, 2021

Conversation

simonjaeger
Copy link
Contributor

Extracted the methods of NodeCache to an interface (INodeCache) to be more easily mocked in unit testing.

@CLAassistant
Copy link

CLAassistant commented Apr 15, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

mregen
mregen approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wonder about the comments-- otherwise looks good

Libraries/Opc.Ua.Client/NodeCache.cs Outdated Show resolved Hide resolved
@AlinMoldovean AlinMoldovean merged commit 0c735eb into OPCFoundation:master Apr 16, 2021
@simonjaeger simonjaeger deleted the refactor/nodecache-interface branch April 16, 2021 08:43
mregen pushed a commit that referenced this pull request Apr 19, 2021
@simonjaeger @mregen
Add interface for NodeCache (#1364)
fc341ee 
* feat: add node cache interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mregen mregen mregen approved these changes

@AlinMoldovean AlinMoldovean AlinMoldovean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@simonjaeger @CLAassistant @mregen @AlinMoldovean