Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NUnit from 3.13.1 to 3.13.2 #1381

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 28, 2021

Bumps NUnit from 3.13.1 to 3.13.2.

Release notes

Sourced from NUnit's releases.

NUnit 3.13.2

This release fixes a new issue with the FixtureLifeCycle attribute where IDisposable test fixtures were not being disposed properly. As always, @​gleb-osokin has been a great help with this new feature.

It also fixes a long-standing performance issue with CollectionAssert.AreEquivalent and the CollectionEquivalentConstraint when comparing large collections. The deep comparison that NUnit performs on the two collections will always have a worst case bound of O(n^2) but we have optimized it so that the majority of use cases will be closer to O(n).

We've also made significant optimizations to the OR filters for selecting tests using their full name. This dramatically improves test performance for large code bases that use dotnet test. Thanks to @​pakrym for his help with this.

For more information, please see the complete Framework Release Notes

Changelog

Sourced from NUnit's changelog.

NUnit 3.13.2 - April 27, 2021

This release fixes a new issue with the FixtureLifeCycle attribute where IDisposable test fixtures were not being disposed properly. As always, @​gleb-osokin has been a great help with this new feature.

It also fixes a long-standing performance issue with CollectionAssert.AreEquivalent and the CollectionEquivalentConstraint when comparing large collections. The deep comparison that NUnit performs on the two collections will always have a worst case bound of O(n^2) but we have optimized it so that the majority of use cases will be closer to O(n).

We've also made significant optimizations to the OR filters for selecting tests using their full name. This dramatically improves test performance for large code bases that use dotnet test. Thanks to @​pakrym for his help with this.

Issues Resolved

  • 2799 CollectionAssert.AreEquivalent is extremely slow
  • 3589 File headers, copyrights, and licenses
  • 3773 IDisposable not working with InstancePerTestCase
  • 3779 Obsolete AreEqual methods with nullable numeric arguments for 3.13
  • 3784 Build the v3.13-dev branch
  • 3786 NUnit with dotnet test results in O(n^2) filtering complexity
  • 3810 Enable deterministic build
  • 3818 AppVeyor failing to build v3.13-dev branch PRs
  • 3832 Deploy v3.13-dev branch builds to MyGet
Commits
  • 5631b49 Merge pull request #3838 from nunit/release3132
  • 18ef24a Fix formatting
  • f7c9845 Update changes for 3.13.2 release
  • 3606fec Merge pull request #3837 from nunit/backport/2799
  • 8008b54 Remove types from test that are not supported in .NET 3.5
  • fbae851 Update src/NUnitFramework/framework/Constraints/CollectionTally.cs
  • 0384ca6 Update src/NUnitFramework/framework/Constraints/CollectionTally.cs
  • 6ec32c7 Update src/NUnitFramework/tests/Constraints/CollectionEquivalentConstraintTes...
  • c3814ff Add support for StringCollection
  • df63dba Performance improvements comparing equivalence of large collections
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 28, 2021
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mregen
Copy link
Contributor

mregen commented Apr 28, 2021

@AlinMoldovean, lets merge this after the MQTT PR...

Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait for MQTT PR

Bumps [NUnit](https://github.com/nunit/nunit) from 3.13.1 to 3.13.2.
- [Release notes](https://github.com/nunit/nunit/releases)
- [Changelog](https://github.com/nunit/nunit/blob/v3.13.2/CHANGES.md)
- [Commits](nunit/nunit@v3.13.1...v3.13.2)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/NUnit-3.13.2 branch from 8549a71 to 6727e7e Compare April 28, 2021 12:31
@mregen mregen merged commit e15605c into master Apr 28, 2021
@mregen mregen deleted the dependabot/nuget/NUnit-3.13.2 branch April 28, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants