Add support for custom certificate stores

[mheege-abb]

Pull request for #1419

[CLAassistant]

All committers have signed the CLA.

[mregen]

Hi @mheege-abb , this is a really nice idea and we had this type of feature on the backlog for quite some time.
However, we need to ensure it works really well with the configuration tools and there are no issues loading e.g. private keys.
I'd suggest a memory based certificate store (we need this anyway for test tooling) as a sample that can be used to test this new interface in depth. Also certvalidator tests should be able to run with that sample cert store, so somebody can test his custom implementation. Would you be able to provide this sample store and tests in addition to this PR?

Thanks, Martin

[mregen]

Hi @mheege-abb, please provide samples and tests with this change --> see my comments.

[mheege-abb]

I will try to fix the typo and the naming and to implement a memory based certificate store this week, but I cannot promise.

Marcus

[mregen]

@mheege-abb great, thanks!

[mregen]

Targeting after next release... it is quite a task, specifically with ECC support coming up.

[mheege-abb]

Targeting after next release... it is quite a task, specifically with ECC support coming up.

Thanks for the info. I hope I will have time to write the tests in the next weeks.
How is the support for custom cert stores related to ECC support?
What is the expected time frame for the release following the next one?

Thanks

Marcus Heege

[mregen]

we will try to squeeze this into the 368 release, due by end of Jan if all goes well..

[mregen]

Hi @mheege-abb, I resolved the merge conflict to get it building. I think this looks good, do you consider your contribution final?

[mregen]

hi @mheege-abb , while fixing the build I figured this is a good time to fix the ICertStore interface too, but to make it fully async introduces a massive number of changes, so I will put it in a different PR. Thanks a lot for your contribution!

[mheege-abb]

Hi @mheege-abb, I resolved the merge conflict to get it building. I think this looks good, do you consider your contribution final?

Yes, please consider my contribution final.

Marcus Heege